Files
opengroupware/tests/unit/services/BoardService.test.ts
Ken Yasue 25d800a529 feat(chat,board): file/image attachments on chat, board threads and comments
チャット・掲示板(スレッド/コメント)へファイル/画像添付を追加。

- lib/db/migrations/002_attachments.sql: attachments テーブル + file_assets.source 列
- repositories/AttachmentRepository + services/AttachmentService: 添付紐付け(プロジェクト/アップロード者チェック)
- FileStorageService.uploadForAttachment: 通知/SSE/アクティビティを行わない添付専用アップロード(source='attachment')
- ChatService/BoardService: fileIds 受理・添付紐付け・履歴/詳細表示・削除クリーンアップ(トランザクション)
- API: POST /attachments + chat/board の fileIds 受理
- UI: AttachmentList(画像サムネイル+Lightbox/ダウンロード) + AttachmentPicker(複数アップロード・送信中は送信不可) をチャット/スレッド/コメントに統合
- 添付ファイルは既存の /api/files/[fileId]/download(権限チェック済)で配信
2026-06-25 10:07:02 +02:00

253 lines
8.4 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { createMigratedTestDb } from '@/tests/helpers/db';
import type { SqliteDatabase } from '@/lib/db/sqlite';
import { UserRepository } from '@/repositories/UserRepository';
import { ProjectRepository } from '@/repositories/ProjectRepository';
import { ProjectMemberRepository } from '@/repositories/ProjectMemberRepository';
import { BoardRepository } from '@/repositories/BoardRepository';
import { FileRepository } from '@/repositories/FileRepository';
import { AttachmentRepository } from '@/repositories/AttachmentRepository';
import { NotificationRepository } from '@/repositories/NotificationRepository';
import { ActivityLogRepository } from '@/repositories/ActivityLogRepository';
import { NotificationService } from '@/services/NotificationService';
import { ActivityLogService } from '@/services/ActivityLogService';
import { AttachmentService } from '@/services/AttachmentService';
import { BoardService } from '@/services/BoardService';
import { ForbiddenError, NotFoundError, ValidationError } from '@/lib/errors';
function makeService(db: SqliteDatabase) {
const members = new ProjectMemberRepository(db);
return new BoardService(
new BoardRepository(db),
members,
new NotificationService(new NotificationRepository(db)),
new ActivityLogService(new ActivityLogRepository(db)),
new AttachmentService(
new AttachmentRepository(db),
new FileRepository(db),
members
),
db
);
}
describe('BoardService', () => {
let db: SqliteDatabase;
let service: BoardService;
let projectId: number;
let authorId: number;
let memberId: number;
let outsiderId: number;
beforeEach(() => {
db = createMigratedTestDb();
service = makeService(db);
const users = new UserRepository(db);
authorId = users.create({
name: 'Author',
email: 'a@example.com',
passwordHash: 'h',
}).id;
memberId = users.create({
name: 'Member',
email: 'm@example.com',
passwordHash: 'h',
}).id;
outsiderId = users.create({
name: 'Outsider',
email: 'o@example.com',
passwordHash: 'h',
}).id;
projectId = new ProjectRepository(db).create({
name: 'P',
ownerId: authorId,
}).id;
const members = new ProjectMemberRepository(db);
members.add(projectId, authorId, 'admin');
members.add(projectId, memberId, 'member');
});
afterEach(() => db.close());
it('allows a member to create a thread and records activity', () => {
const thread = service.createThread(memberId, projectId, {
title: 'T',
bodyMd: 'body',
category: 'notice',
});
expect(thread.title).toBe('T');
const logs = new ActivityLogRepository(db).findByProject(projectId);
expect(logs.items.some((l) => l.action === 'board_posted')).toBe(true);
});
it('forbids a non-member from creating a thread', () => {
expect(() =>
service.createThread(outsiderId, projectId, { title: 'T', bodyMd: 'b' })
).toThrow(ForbiddenError);
});
it('rejects an empty title', () => {
expect(() =>
service.createThread(memberId, projectId, { title: ' ', bodyMd: 'b' })
).toThrow(ValidationError);
});
it('only the author or admin can edit/delete a thread', () => {
const users = new UserRepository(db);
const member2 = users.create({
name: 'Member2',
email: 'm2@example.com',
passwordHash: 'h',
}).id;
new ProjectMemberRepository(db).add(projectId, member2, 'member');
const thread = service.createThread(memberId, projectId, {
title: 'T',
bodyMd: 'b',
});
// 非作者かつ非管理者は編集不可
expect(() =>
service.updateThread(member2, thread.id, { title: 'X' })
).toThrow(ForbiddenError);
// 管理者は編集可
expect(() =>
service.updateThread(authorId, thread.id, { title: 'X' })
).not.toThrow();
// 作者自身は編集可
expect(() =>
service.updateThread(memberId, thread.id, { title: 'Y' })
).not.toThrow();
// 外部者はアクセス不可
expect(() => service.getThread(outsiderId, thread.id)).toThrow(
ForbiddenError
);
});
it('creates a comment, notifies the thread author (not the commenter), and logs activity', () => {
const thread = service.createThread(authorId, projectId, {
title: 'T',
bodyMd: 'b',
});
const comment = service.createComment(memberId, thread.id, 'nice post');
expect(comment.bodyMd).toBe('nice post');
// 通知はスレッド投稿者(authorId)へ
const notifs = new NotificationRepository(db).findUnreadByUser(authorId);
expect(notifs.total).toBe(1);
// コメントした本人には通知しない
expect(new NotificationRepository(db).countUnreadByUser(memberId)).toBe(0);
const logs = new ActivityLogRepository(db).findByProject(projectId);
expect(logs.items.some((l) => l.action === 'comment_added')).toBe(true);
});
it('does not notify when the author comments on their own thread', () => {
const thread = service.createThread(authorId, projectId, {
title: 'T',
bodyMd: 'b',
});
service.createComment(authorId, thread.id, 'self comment');
expect(new NotificationRepository(db).countUnreadByUser(authorId)).toBe(0);
});
it('only the comment author can edit their comment', () => {
const thread = service.createThread(authorId, projectId, {
title: 'T',
bodyMd: 'b',
});
const comment = service.createComment(memberId, thread.id, 'c');
expect(() => service.updateComment(authorId, comment.id, 'hacked')).toThrow(
ForbiddenError
);
expect(service.updateComment(memberId, comment.id, 'edited').bodyMd).toBe(
'edited'
);
});
it('admin can delete another member comment', () => {
const thread = service.createThread(authorId, projectId, {
title: 'T',
bodyMd: 'b',
});
const comment = service.createComment(memberId, thread.id, 'c');
service.deleteComment(authorId, comment.id); // authorId is admin
expect(() => service.listComments(memberId, thread.id)).not.toThrow();
});
it('throws NotFoundError for a non-existent thread', () => {
expect(() => service.getThread(memberId, 99999)).toThrow(NotFoundError);
});
it('createThread with fileIds attaches files to the thread', () => {
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: memberId,
filename: 'a.png',
originalName: 'a.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/a.png',
source: 'attachment',
});
const thread = service.createThread(memberId, projectId, {
title: 'T',
bodyMd: 'b',
fileIds: [f1.id],
});
const atts = service.getAttachments(memberId, thread.id, []);
expect(atts.thread).toHaveLength(1);
expect(atts.thread[0].fileId).toBe(f1.id);
});
it('createComment with fileIds attaches files to the comment', () => {
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: memberId,
filename: 'c.png',
originalName: 'c.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/c.png',
source: 'attachment',
});
const thread = service.createThread(authorId, projectId, {
title: 'T',
bodyMd: 'b',
});
const comment = service.createComment(memberId, thread.id, 'c', [f1.id]);
const atts = service.getAttachments(memberId, thread.id, [comment.id]);
expect(atts.comments).toHaveLength(1);
expect(atts.comments[0].targetId).toBe(comment.id);
});
it('deleteThread and deleteComment detach attachments', () => {
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: memberId,
filename: 'a.png',
originalName: 'a.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/a.png',
source: 'attachment',
});
const thread = service.createThread(memberId, projectId, {
title: 'T',
bodyMd: 'b',
fileIds: [f1.id],
});
// 削除前は添付あり
expect(
new AttachmentRepository(db).findByTarget('board_thread', thread.id)
).toHaveLength(1);
service.deleteThread(memberId, thread.id);
// 削除後は論理削除されて取得できない
expect(
new AttachmentRepository(db).findByTarget('board_thread', thread.id)
).toHaveLength(0);
});
});