Files
opengroupware/tests/unit/services/TodoService.test.ts
Ken Yasue 03cf27a148 fix(chat,todo): show sent chat messages immediately + kanban drag-and-drop reorder
チャット送信の即時表示とKanbanのDnD並べ替えを修正。

- chat: 送信成功時に返却メッセージを楽観的にローカルへ先頭追加(SSE到着前でも即表示、idで重複排除)。setSending(false) をレスポンス処理後に移動し二重送信窓を縮小。
- todo: TodoService.reorderItems(projectId, columnId, itemIds[]) を追加(1トランザクションでカラム内を再採番、メンバーシップ+同プロジェクト検証、活動ログ/SSEは1件)。POST /todos/items/reorder を追加。
- KanbanBoard: カード単位のドロップターゲット(ポインタYで前/後挿入)+カラム空き領域は末尾追加。楽観的にorderIndex/columnIdを更新しrenderをorderIndexでソート(即時反映)、失敗時はエラー表示+再取得で巻き戻し。ドラッグ直後の誤クリック(ダイアログ誘起)をdragEndタイムスタンプで抑制。空の並べ替えはSSE/ログを出さない。
2026-06-25 13:06:05 +02:00

385 lines
12 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { createMigratedTestDb } from '@/tests/helpers/db';
import type { SqliteDatabase } from '@/lib/db/sqlite';
import { UserRepository } from '@/repositories/UserRepository';
import { ProjectRepository } from '@/repositories/ProjectRepository';
import { ProjectMemberRepository } from '@/repositories/ProjectMemberRepository';
import { TodoRepository } from '@/repositories/TodoRepository';
import { FileRepository } from '@/repositories/FileRepository';
import { AttachmentRepository } from '@/repositories/AttachmentRepository';
import { NotificationRepository } from '@/repositories/NotificationRepository';
import { ActivityLogRepository } from '@/repositories/ActivityLogRepository';
import { NotificationService } from '@/services/NotificationService';
import { ActivityLogService } from '@/services/ActivityLogService';
import { AttachmentService } from '@/services/AttachmentService';
import { TodoService } from '@/services/TodoService';
import { SseHub } from '@/lib/sse/hub';
import { ForbiddenError, NotFoundError } from '@/lib/errors';
function makeService(db: SqliteDatabase) {
const hub = new SseHub();
const members = new ProjectMemberRepository(db);
const users = new UserRepository(db);
return {
hub,
service: new TodoService(
new TodoRepository(db),
members,
new NotificationService(new NotificationRepository(db)),
new ActivityLogService(new ActivityLogRepository(db)),
hub,
new AttachmentService(
new AttachmentRepository(db),
new FileRepository(db),
members
),
db
),
members,
users,
};
}
describe('TodoService', () => {
let db: SqliteDatabase;
let service: TodoService;
let projectId: number;
let authorId: number;
let memberId: number;
let outsiderId: number;
beforeEach(() => {
db = createMigratedTestDb();
const ctx = makeService(db);
service = ctx.service;
const users = ctx.users;
authorId = users.create({
name: 'A',
email: 'a@example.com',
passwordHash: 'h',
}).id;
memberId = users.create({
name: 'M',
email: 'm@example.com',
passwordHash: 'h',
}).id;
outsiderId = users.create({
name: 'O',
email: 'o@example.com',
passwordHash: 'h',
}).id;
projectId = new ProjectRepository(db).create({
name: 'P',
ownerId: authorId,
}).id;
ctx.members.add(projectId, authorId, 'admin');
ctx.members.add(projectId, memberId, 'member');
});
afterEach(() => db.close());
it('auto-creates the 5 standard columns on first getColumns', () => {
const cols = service.getColumns(authorId, projectId);
expect(cols.map((c) => c.name)).toEqual([
'Backlog',
'To Do',
'In Progress',
'Review',
'Done',
]);
});
it('forbids a non-member from accessing columns', () => {
expect(() => service.getColumns(outsiderId, projectId)).toThrow(
ForbiddenError
);
});
it('creates an item with assignee → todo_assigned notification + todo_created activity', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(authorId, projectId, {
title: 'task',
columnId: col.id,
assigneeId: memberId,
priority: 'high',
});
expect(item.assigneeId).toBe(memberId);
expect(new NotificationRepository(db).countUnreadByUser(memberId)).toBe(1);
expect(
new ActivityLogRepository(db)
.findByProject(projectId)
.items.some((l) => l.action === 'todo_created')
).toBe(true);
});
it('does not notify when assigning to self', () => {
const col = service.getColumns(authorId, projectId)[0];
service.createItem(authorId, projectId, {
title: 'self',
columnId: col.id,
assigneeId: authorId,
});
expect(new NotificationRepository(db).countUnreadByUser(authorId)).toBe(0);
});
it('toggling complete sets completedAt and logs todo_completed', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
});
const completed = service.toggleComplete(authorId, item.id);
expect(completed.completedAt).not.toBeNull();
expect(
new ActivityLogRepository(db)
.findByProject(projectId)
.items.some((l) => l.action === 'todo_completed')
).toBe(true);
// もう一度トグルで未完了に戻る
const reopened = service.toggleComplete(authorId, item.id);
expect(reopened.completedAt).toBeNull();
});
it('moves an item to another column', () => {
const cols = service.getColumns(authorId, projectId);
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: cols[0].id,
});
const moved = service.moveItem(authorId, item.id, cols[4].id, 0);
expect(moved.columnId).toBe(cols[4].id);
});
it('only creator or admin can delete an item', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(memberId, projectId, {
title: 't',
columnId: col.id,
});
expect(() => service.deleteItem(outsiderId, item.id)).toThrow(
ForbiddenError
);
service.deleteItem(authorId, item.id); // admin
expect(() => service.toggleComplete(memberId, item.id)).toThrow(
NotFoundError
);
});
it('throws NotFoundError for a non-existent item', () => {
expect(() => service.toggleComplete(authorId, 99999)).toThrow(
NotFoundError
);
});
it('createItem persists startDate/tags and attaches files', () => {
const col = service.getColumns(authorId, projectId)[0];
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: authorId,
filename: 'a.png',
originalName: 'a.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/a.png',
source: 'attachment',
});
const item = service.createItem(authorId, projectId, {
title: 'rich',
columnId: col.id,
startDate: '2026-07-01',
dueDate: '2026-07-31',
tags: 'frontend,urgent',
fileIds: [f1.id],
});
expect(item.startDate).toBe('2026-07-01');
expect(item.tags).toBe('frontend,urgent');
expect(service.getItemAttachments(authorId, item.id)).toHaveLength(1);
});
it('updateItem updates startDate/tags and attaches new files', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
});
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: authorId,
filename: 'b.png',
originalName: 'b.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/b.png',
source: 'attachment',
});
const updated = service.updateItem(authorId, item.id, {
description: 'desc',
startDate: '2026-08-01',
tags: 'backend',
fileIds: [f1.id],
});
expect(updated.description).toBe('desc');
expect(updated.startDate).toBe('2026-08-01');
expect(updated.tags).toBe('backend');
expect(service.getItemAttachments(authorId, item.id)).toHaveLength(1);
});
it('deleteItem detaches its attachments', () => {
const col = service.getColumns(authorId, projectId)[0];
const fileRepo = new FileRepository(db);
const f1 = fileRepo.create({
projectId,
uploaderId: authorId,
filename: 'a.png',
originalName: 'a.png',
mimeType: 'image/png',
size: 1,
path: '/tmp/a.png',
source: 'attachment',
});
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
fileIds: [f1.id],
});
expect(service.getItemAttachments(authorId, item.id)).toHaveLength(1);
service.deleteItem(authorId, item.id);
expect(
new AttachmentRepository(db).findByTarget('todo_item', item.id)
).toHaveLength(0);
});
it('getItem and getItemAttachments enforce membership', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
});
expect(service.getItem(authorId, item.id).id).toBe(item.id);
expect(() => service.getItem(outsiderId, item.id)).toThrow(ForbiddenError);
expect(() => service.getItemAttachments(outsiderId, item.id)).toThrow(
ForbiddenError
);
});
it('only the creator or an admin can delete an item (member-but-not-creator cannot)', () => {
const col = service.getColumns(authorId, projectId)[0];
// authorId(admin)が作成したアイテムを memberId(非管理者・非作成者)は削除できない
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
});
expect(() => service.deleteItem(memberId, item.id)).toThrow(ForbiddenError);
// admin(作成者)は削除可
service.deleteItem(authorId, item.id);
expect(() => service.getItem(authorId, item.id)).toThrow(NotFoundError);
});
it('deleteColumn: admin can delete, non-admin member cannot', () => {
const col = service.getColumns(authorId, projectId)[0];
// memberId(非管理者)はカラム削除不可
expect(() => service.deleteColumn(memberId, col.id)).toThrow(
ForbiddenError
);
// authorId(admin)は削除可
service.deleteColumn(authorId, col.id);
expect(() => service.updateColumn(authorId, col.id, { name: 'x' })).toThrow(
NotFoundError
);
});
it('clears startDate/tags/assigneeId via null on update', () => {
const col = service.getColumns(authorId, projectId)[0];
const item = service.createItem(authorId, projectId, {
title: 't',
columnId: col.id,
startDate: '2026-07-01',
tags: 'a,b',
assigneeId: memberId,
});
const cleared = service.updateItem(authorId, item.id, {
startDate: null,
tags: null,
assigneeId: null,
});
expect(cleared.startDate).toBeNull();
expect(cleared.tags).toBeNull();
expect(cleared.assigneeId).toBeNull();
});
describe('reorderItems', () => {
it('renumbers items within a column in the given order', () => {
const cols = service.getColumns(authorId, projectId);
const col = cols[0];
const a = service.createItem(authorId, projectId, {
title: 'A',
columnId: col.id,
});
const b = service.createItem(authorId, projectId, {
title: 'B',
columnId: col.id,
});
const c = service.createItem(authorId, projectId, {
title: 'C',
columnId: col.id,
});
// 逆順に並べ替え
const result = service.reorderItems(authorId, projectId, col.id, [
c.id,
b.id,
a.id,
]);
expect(result.map((i) => i.title)).toEqual(['C', 'B', 'A']);
expect(result.map((i) => i.orderIndex)).toEqual([0, 1, 2]);
});
it('moves an item from another column into the target position', () => {
const cols = service.getColumns(authorId, projectId);
const src = cols[0];
const dest = cols[1];
const a = service.createItem(authorId, projectId, {
title: 'A',
columnId: dest.id,
});
const b = service.createItem(authorId, projectId, {
title: 'B',
columnId: dest.id,
});
const x = service.createItem(authorId, projectId, {
title: 'X',
columnId: src.id,
});
// X を A と B の間に挿入
service.reorderItems(authorId, projectId, dest.id, [a.id, x.id, b.id]);
const destItems = service
.getItems(authorId, projectId)
.filter((i) => i.columnId === dest.id);
expect(destItems.map((i) => i.title)).toEqual(['A', 'X', 'B']);
// X は元のカラムからいなくなる
const srcItems = service
.getItems(authorId, projectId)
.filter((i) => i.columnId === src.id);
expect(srcItems.find((i) => i.id === x.id)).toBeUndefined();
});
it('forbids a non-member from reordering', () => {
const col = service.getColumns(authorId, projectId)[0];
expect(() =>
service.reorderItems(outsiderId, projectId, col.id, [])
).toThrow(ForbiddenError);
});
it('rejects an unknown column or item', () => {
const col = service.getColumns(authorId, projectId)[0];
expect(() =>
service.reorderItems(authorId, projectId, 99999, [])
).toThrow(NotFoundError);
expect(() =>
service.reorderItems(authorId, projectId, col.id, [99999])
).toThrow(NotFoundError);
});
});
});